Merged
Conversation
Code quality scoreLovely, the code quality is unchanged for this PR 😊
|
hapiben
requested changes
Oct 10, 2025
Comment on lines
+5
to
+7
| # Uncomment each configuration one by one to switch to the new default. | ||
| # Once your application is ready to run with all new defaults, you can remove | ||
| # this file and set the `config.load_defaults` to `7.2`. |
Member
There was a problem hiding this comment.
todo: This file is only needed to test if the 7.2 features work with the current codebase. You can remove this file if you're done with it.
Contributor
Author
There was a problem hiding this comment.
ok I'll likely end up removing this
config/application.rb
Outdated
| # require "action_mailbox/engine" | ||
| # require "action_text/engine" | ||
| # require "action_view/railtie" | ||
| require "action_view/railtie" |
Member
There was a problem hiding this comment.
question: Do we need this enabled?
Contributor
Author
There was a problem hiding this comment.
I don't think so, so I'll comment out
chigginsboost
approved these changes
Oct 10, 2025
hapiben
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manager Rails 7.2
As a Software Developer, I want to upgrade our Rails application from 7.1.5.1 to 7.2 so that we maintain support on the current Rails version
Acceptance Criteria: